Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/mdc-button): support custom leading/trailing icons #24987

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label May 27, 2022
@mmalerba mmalerba requested a review from andrewseguin as a code owner May 27, 2022 17:15
@mmalerba
Copy link
Contributor Author

It occurs to me that an alternate solution to this could be to just document adding ngProjectAs="mat-icon" to the content. I wonder if <div ngProjectAs="mat-icon" iconPositionEnd> would work though. Or maybe people would need to do <div ngProjectAs="mat-icon[iconPositionEnd]">?

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jun 13, 2022
@mmalerba mmalerba assigned mmalerba and unassigned andrewseguin Jun 13, 2022
@mmalerba mmalerba merged commit 864f92e into angular:main Jun 14, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants