Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): add i18n strings #25024

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Jun 3, 2022

Add i18n strings for "Start Date" and "End Date". Add formatYearRangeLabel to format a year of
dates in a screen reader friendly way (e.g. "2019 to 2020"). The existing method, formatYearRange,
uses a dash character which does not read well on screen readers.

These three new strings are not used in this commit. They will be used in future commits as aria
labels and descriptions to fix accessibility bugs.

@zarend zarend added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release area: material/datepicker labels Jun 3, 2022
@zarend
Copy link
Contributor Author

zarend commented Jun 3, 2022

internal presubmit

@zarend zarend added the i18n This issue is related to internationalization label Jun 3, 2022
@zarend zarend marked this pull request as ready for review June 3, 2022 18:45
@zarend zarend requested review from mmalerba and crisbeto as code owners June 3, 2022 18:45
@zarend zarend force-pushed the datepicker-i18n branch from 85864dc to bc2587d Compare June 3, 2022 21:40
@zarend zarend added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 3, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 6, 2022
Add i18n strings for "Start Date" and "End Date". Add `formatYearRangeLabel` to format a year of
dates in a screen reader friendly way (e.g. "2019 to 2020"). The existing method, `formatYearRange`,
uses a dash character which does not read well on screen readers.

These three new strings are not used in this commit. They will be used in future commits as aria
labels and descriptions to fix accessibility bugs.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/datepicker i18n This issue is related to internationalization target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants