fix(cdk/scrolling): content jumping in appendOnly mode #25097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were creating the `transform` string before adjusting the offset for `appendOnly` mode which was causing the list to jump down before being reset on the next scroll event. These changes resolve the issue by moving the offset adjustment up to before the `transform`. Fixes angular#25077.
crisbeto
added
P3
crisbeto
added a commit
that referenced
this pull request
Jun 18, 2022
We were creating the `transform` string before adjusting the offset for `appendOnly` mode which was causing the list to jump down before being reset on the next scroll event. These changes resolve the issue by moving the offset adjustment up to before the `transform`. Fixes #25077. (cherry picked from commit f6bcbb1)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 28, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.2/14.0.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.2` -> `14.0.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.2/14.0.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.0.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1403-diamond-orb-2022-06-23) [Compare Source](angular/components@14.0.2...14.0.3) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [2ad1677c7](angular/components@2ad1677) | fix | **scrolling:** content jumping in appendOnly mode ([#​25097](angular/components#25097)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [8d5882cf1](angular/components@8d5882c) | fix | **button-toggle:** selected state not visible in high contrast mode ([#​25114](angular/components#25114)) | | [8df5efe08](angular/components@8df5efe) | fix | **datepicker:** actions not re-rendering if swapped out while calendar is open ([#​25123](angular/components#25123)) | #### Special Thanks Kristiyan Kostadinov, Paul Gschwendtner and renovate\[bot] <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1432 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This was referenced Jul 1, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were creating the
transformstring before adjusting the offset forappendOnlymode which was causing the list to jump down before being reset on the next scroll event.These changes resolve the issue by moving the offset adjustment up to before the
transform.Fixes #25077.