Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix incorrect usage in theming tests #25259

Merged
merged 1 commit into from
Jul 12, 2022
Merged

test: fix incorrect usage in theming tests #25259

merged 1 commit into from
Jul 12, 2022

Conversation

devversion
Copy link
Member

When we switched to the @use API we did not update some of the tests.
#22173

@devversion
test: fix incorrect usage in theming tests
f38f784 
When we switched to the `@use` API we did not update some of the tests.
angular#22173
@devversion devversion requested a review from crisbeto July 12, 2022 11:08
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jul 12, 2022
@devversion
Copy link
Member Author

Note: in the future when we finally remove the legacy theming bundle + the .import files, we should also rework this test to use the @use. This is out of scope in this PR which just attempts to fix some warnings in the Bazel build

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jul 12, 2022
@devversion devversion merged commit c28bbde into angular:main Jul 12, 2022
devversion added a commit that referenced this pull request Jul 12, 2022
@devversion
test: fix incorrect usage in theming tests (#25259)
beffbfc 
When we switched to the `@use` API we did not update some of the tests.
#22173

(cherry picked from commit c28bbde)
devversion added a commit that referenced this pull request Jul 12, 2022
@devversion
test: fix incorrect usage in theming tests (#25259)
40d34eb 
When we switched to the `@use` API we did not update some of the tests.
#22173

(cherry picked from commit c28bbde)
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 19, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devversion @crisbeto