Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(material/custom-form-field): fixed propname #25328

Merged
merged 1 commit into from
Aug 16, 2022
Merged

docs(material/custom-form-field): fixed propname #25328

merged 1 commit into from
Aug 16, 2022

Conversation

ApplY3D
Copy link
Contributor

@ApplY3D ApplY3D commented Jul 23, 2022

not defined elRef was changed on defined _elementRef

@ApplY3D
docs(material/custom-form-field): fixed propname
82eeaf0 
not defined `elRef` was changed on defined `_elementRef`
@ApplY3D ApplY3D requested a review from jelbourn as a code owner July 23, 2022 07:57
@google-cla
Copy link

google-cla bot commented Jul 23, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jelbourn
jelbourn approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed docs This issue is related to documentation labels Aug 12, 2022
@andrewseguin andrewseguin merged commit a2eb778 into angular:main Aug 16, 2022
andrewseguin pushed a commit that referenced this pull request Aug 16, 2022
@ApplY3D @andrewseguin
docs(material/form-field): fixed propname in guide (#25328)
c6a03f1 
not defined `elRef` was changed on defined `_elementRef`

(cherry picked from commit a2eb778)
andrewseguin pushed a commit that referenced this pull request Aug 16, 2022
@ApplY3D @andrewseguin
docs(material/form-field): fixed propname in guide (#25328)
b477b63 
not defined `elRef` was changed on defined `_elementRef`

(cherry picked from commit a2eb778)
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 23, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2022
@andrewseguin andrewseguin self-assigned this Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ApplY3D @jelbourn @andrewseguin