fix(material/core): add typography to prebuilt themes #25696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: major
andrewseguin
force-pushed
the
prebuilt-typography
branch
2 times, most recently
from
d3809c7 to
220b308
Compare
devversion
approved these changes
Sep 24, 2022
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
yeah, this transition phase is not ideal- but the ideal state is definitely explicit
andrewseguin
force-pushed
the
prebuilt-typography
branch
from
220b308 to
8862e6d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a typography config to the prebuilt themes. I suspect people copy/paste this file, so it'd be best if we make it a good example. Unfortunately, this means typography styles are duplicated because
coreis also emitting typography, but getting rid of that functionality in core will be a bit more work. For now, this PR values correct theme config code over style bloat (which prebuilts will have anyways for 99% of apps)Running this over internal tests to confirm this is not breaking