fix(material/icon): forward fontIcon attribute to element #25779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In angular#24578 we added the ability to set font icons using the `fontIcon` input, however it was never forwarded to the `fontIcon` attribute which means using a data binding won't work. Fixes angular#25759.
crisbeto
added
P2
andrewseguin
approved these changes
Oct 10, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Oct 13, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.4` -> `14.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.4/14.2.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.4` -> `14.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.4/14.2.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1425-hail-heron-2022-10-12) [Compare Source](angular/components@14.2.4...14.2.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [b116f57d16](angular/components@b116f57) | fix | **drag-drop:** native event not passed as parameter to drop container ([#​25763](angular/components#25763)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [79eab3838d](angular/components@79eab38) | fix | **icon:** forward fontIcon attribute to element ([#​25779](angular/components#25779)) | #### Special Thanks Joe K, Joey Perrott and Kristiyan Kostadinov <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjIzNi4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1583 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24578 we added the ability to set font icons using the
fontIconinput, however it was never forwarded to thefontIconattribute which means using a data binding won't work.Fixes #25759.