fix(material/datepicker): date range inputs not aligning in some cases #25967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use two different approaches to align the start and end parts of the date range. The start is absolutely-positioned while the end is `relative` which ends up misaligning on some browsers and typography configurations. These changes make both positioned absolutely since some browsers don't handle `line-height` on inputs reliably. Fixes angular#25955.
crisbeto
added
P3
crisbeto
added
target: patch
crisbeto
added a commit
that referenced
this pull request
Nov 16, 2022
#25967) Currently we use two different approaches to align the start and end parts of the date range. The start is absolutely-positioned while the end is `relative` which ends up misaligning on some browsers and typography configurations. These changes make both positioned absolutely since some browsers don't handle `line-height` on inputs reliably. Fixes #25955. (cherry picked from commit 7d268b5)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use two different approaches to align the start and end parts of the date range. The start is absolutely-positioned while the end is
relativewhich ends up misaligning on some browsers and typography configurations.These changes make both positioned absolutely since some browsers don't handle
line-heighton inputs reliably.Fixes #25955.