fix(material/chips): change div to span #26343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `MatChip` component, change the `<div/>` element for the primary action to a span element. Fix problem where the div is nested inside a span. A span is a container for phrasing content and is not supposed to contain flow content. This could also potentialy cause accessibility issue. Correct the semantics by nesting a span inside another span.
zarend
added
target: patch
|
I'm merging this PR, because the corresponding internal change was submitted already which is causing the repo to be out of sync. |
crisbeto
pushed a commit
that referenced
this pull request
Jan 9, 2023
For `MatChip` component, change the `<div/>` element for the primary action to a span element. Fix problem where the div is nested inside a span. A span is a container for phrasing content and is not supposed to contain flow content. This could also potentialy cause accessibility issue. Correct the semantics by nesting a span inside another span. (cherry picked from commit 14919bd)
crisbeto
pushed a commit
that referenced
this pull request
Jan 9, 2023
For `MatChip` component, change the `<div/>` element for the primary action to a span element. Fix problem where the div is nested inside a span. A span is a container for phrasing content and is not supposed to contain flow content. This could also potentialy cause accessibility issue. Correct the semantics by nesting a span inside another span. (cherry picked from commit 14919bd)
|
My mistake, thanks for catching 🤦 . |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jan 13, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`15.0.4` -> `15.1.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.0.4/15.1.0) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`15.0.4` -> `15.1.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.0.4/15.1.0) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.1.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1510-silk-sandal-2023-01-11) [Compare Source](angular/components@15.0.4...15.1.0) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [e0a74b9c2b](angular/components@e0a74b9) | feat | **menu:** Allow setting cdkMenuTriggerFor null ([#​25818](angular/components#25818)) | | [b0f0b5b162](angular/components@b0f0b5b) | fix | **drag-drop:** receiving class not updated in OnPush component ([#​26386](angular/components#26386)) | | [836b777526](angular/components@836b777) | fix | **menu:** don't prevent default selection key actions ([#​26296](angular/components#26296)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [8554e15383](angular/components@8554e15) | feat | **datepicker:** Support drag and drop to adjust date ranges ([#​25548](angular/components#25548)) | | [c370e064d4](angular/components@c370e06) | feat | **tabs:** add a harness filter for tab selected state ([#​25806](angular/components#25806)) | | [44657e2624](angular/components@44657e2) | fix | **autocomplete:** apply theme of parent form field to panel ([#​25983](angular/components#25983)) | | [9b1f49f6f2](angular/components@9b1f49f) | fix | **chips:** add support for aria-description ([#​25935](angular/components#25935)) | | [8b19fd9e29](angular/components@8b19fd9) | fix | **chips:** change div to span ([#​26343](angular/components#26343)) | | [dcf2fac042](angular/components@dcf2fac) | fix | **chips:** implement ariaDescription with aria-describedby ([#​26105](angular/components#26105)) | | [e536ce0736](angular/components@e536ce0) | fix | **core:** default font family not applied to custom typography levels ([#​26394](angular/components#26394)) | | [d02cc6817c](angular/components@d02cc68) | fix | **datepicker:** fix date picker shortcuts ([#​25951](angular/components#25951)) | | [4da9e1944a](angular/components@4da9e19) | fix | **datepicker:** Update strategy to handle dragging across month boundaries and/or DateAdapter implementations that do not return difference in days from compareDate ([#​26341](angular/components#26341)) | | [25d9217fd1](angular/components@25d9217) | fix | **list:** add opt-out for radio indicators ([#​26283](angular/components#26283)) | | [57676e467a](angular/components@57676e4) | fix | **list:** add radio toggles ([#​25933](angular/components#25933)) | | [5b57863702](angular/components@5b57863) | fix | **list:** align color scheme between single and multi selection list ([#​26074](angular/components#26074)) | | [1819d3027b](angular/components@1819d30) | fix | **tabs:** allow focus on disabled tabs ([#​26397](angular/components#26397)) | #### Special Thanks Amy Sorto, David Klingenberg, Joey Perrott, Karl Seamon, Kristiyan Kostadinov, Miles Malerba, Sasidharan SD, Wagner Maciel and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45Ny41IiwidXBkYXRlZEluVmVyIjoiMzQuMTAwLjEifQ==--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1723 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
MatChipcomponent, change the<div/>element for the primary action to a span element. Fix problem where the div is nested inside a span. A span is a container for phrasing content and is not supposed to contain flow content. This could also potentialy cause accessibility issue. Correct the semantics by nesting a span inside another span.