Skip to content

Conversation

@zarend
Copy link
Contributor

@zarend zarend commented Jan 5, 2023

Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for #25890 and
#26338.

@zarend zarend added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation area: material/chips labels Jan 5, 2023
@zarend zarend requested a review from jelbourn January 5, 2023 19:42
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 5, 2023
@zarend zarend marked this pull request as draft January 6, 2023 17:28
@zarend zarend force-pushed the docs-chips-single-select branch 2 times, most recently from 5814f67 to d3bb4e9 Compare January 9, 2023 18:25
@zarend zarend marked this pull request as ready for review January 9, 2023 18:26
@zarend
Copy link
Contributor Author

zarend commented Jan 9, 2023

@crisbeto I reworded this. Do the punctuation and wording look better than before?

@zarend zarend requested a review from crisbeto January 9, 2023 18:27
@zarend zarend added the target: minor This PR is targeted for the next minor release label Jan 9, 2023
@zarend zarend force-pushed the docs-chips-single-select branch 3 times, most recently from 3f9afe6 to ea36e98 Compare January 10, 2023 17:44
Update the accessibility section on checkmark indicators for
single-selection. Add instructions to always communicate selection with
icon indicators. Fulfill documentation needs as follow-up for angular#25890 and
 angular#26338.
@zarend zarend force-pushed the docs-chips-single-select branch from ea36e98 to 8dd0d40 Compare January 10, 2023 19:10
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Jan 10, 2023
@angular-robot angular-robot bot merged commit 1f0feb1 into angular:main Jan 10, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/chips docs This issue is related to documentation target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants