Skip to content

docs(material/select, material/autocomplete): update a11y docs on che… #26515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

docs(material/select, material/autocomplete): update a11y docs on che… #26515

merged 1 commit into from
Feb 10, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Jan 27, 2023

…ckmark indicators

Update the accessibility section on checkmark indicators for single-selection. Add instructions to always communicate selection with icon indicators. Fulfill documentation needs as follow-up for #25962.

@zarend zarend added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation area: material/autocomplete area: material/select labels Jan 27, 2023
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jan 27, 2023
@zarend
docs(multiple): update a11y docs on checkmark indicators
210a318 
For Select and Autocomplete components, update the accessibility section on
heckmark indicators for single-selection. Add instructions to always communicate
with icon indicators. Fulfill documentation needs as follow-up for
PR angular#25962.
@zarend zarend force-pushed the mat-option-checkmark-docs branch from 5913a49 to 210a318 Compare January 27, 2023 19:02
@zarend zarend marked this pull request as ready for review February 7, 2023 18:51
@zarend zarend requested a review from crisbeto as a code owner February 7, 2023 18:51
crisbeto
crisbeto approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Feb 8, 2023
@angular-robot angular-robot bot merged commit 6593954 into angular:main Feb 10, 2023
angular-robot bot pushed a commit that referenced this pull request Feb 10, 2023
@zarend
docs(multiple): update a11y docs on checkmark indicators (#26515)
4250ac4 
For Select and Autocomplete components, update the accessibility section on
heckmark indicators for single-selection. Add instructions to always communicate
with icon indicators. Fulfill documentation needs as follow-up for
PR #25962.

(cherry picked from commit 6593954)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/autocomplete area: material/select docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarend @crisbeto