-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/slider): make valueChange emit only on change and not on… #26535
Conversation
Is there a bug associated with this? |
Yes - #26496 |
Since the new behavior is just different and not wrong, maybe it would be nice to switch the behavior (keeping the old one as default)? If interessnted, I'd adopt the PR regardingly. |
@angelaki Technically the new behavior is wrong. The valueChange event should only emit on value change which is different from on input |
@wagnermaciel Ah, I see! If I'm interessted in all the intermediate values I should listen to |
@angelaki Hey, yep you're right. With the latest implementation of the slider, the native browser inputs are exposed, which means you can just listen to I believe the syntax should be something like this: <mat-slider>
<input matSliderThumb (input)="handleInput($event)">
</mat-slider> |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.1.4` -> `15.1.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.1.4/15.1.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.1.4` -> `15.1.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.1.4/15.1.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.1.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1515-highdensityfoam-pelican-2023-02-16) [Compare Source](angular/components@15.1.4...15.1.5) ##### material | Commit | Type | Description | | -- | -- | -- | | [994e0a14c](angular/components@994e0a1) | fix | **core:** Fix legacy prebuilt themes export ([#​26624](angular/components#26624)) | | [4c8cad2d2](angular/components@4c8cad2) | fix | **radio:** input not focused when clicking on touch target ([#​26618](angular/components#26618)) | | [890765bf4](angular/components@890765b) | fix | **slider:** make valueChange emit only on change and not on input ([#​26535](angular/components#26535)) | #### Special Thanks Kai Schönberger, Kristiyan Kostadinov, Lukáš Matta, Wagner Maciel, Zach Arend and ᚷᛁᛟᚱᚷᛁ ᛒᚨᛚᚨᚲᚻᚨᛞᛉᛖ <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0MS4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1788 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
… input
Fixes #26496