fix(cdk/dialog): not emitting closed event on external detachments #26608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
devversion,
jelbourn and
josephperrott
as code owners
crisbeto
commented
Feb 12, 2023
devversion
approved these changes
Feb 20, 2023
crisbeto
force-pushed
the
26581/dialog-external-detachments
branch
from
34c529d to
1bb8361
Compare
crisbeto
force-pushed
the
26581/dialog-external-detachments
branch
from
1bb8361 to
c82ba26
Compare
Fixes that the CDK dialog wasn't emitting to the `closed` event when it is detached externally, e.g. by a scroll strategy or a navigation. We had unit tests for this on the Material side, but we had special logic to handle it there. Fixes angular#26581.
crisbeto
force-pushed
the
26581/dialog-external-detachments
branch
from
c82ba26 to
470e3f0
Compare
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Feb 23, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.1.5/15.2.0) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`15.1.5` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.1.5/15.2.0) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.2.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1520-sodalite-soda-2023-02-22) [Compare Source](angular/components@15.1.6...15.2.0) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [62bd54e8e](angular/components@62bd54e) | feat | **testing:** add method to set the text of an element | ##### material | Commit | Type | Description | | -- | -- | -- | | [b42650c88](angular/components@b42650c) | feat | **chips:** add test harness support for edit input | | [5e96eb04c](angular/components@5e96eb0) | fix | **chips:** add opt-out for single-select checkmarks ([#​26338](angular/components#26338)) | | [46cfbe566](angular/components@46cfbe5) | fix | **core:** add checkmark for single-select ([#​25962](angular/components#25962)) | #### Special Thanks Amy Sorto, Hamza jayri, Jonas Brems, Kristiyan Kostadinov, Miles Malerba, Paul Gschwendtner, Wagner Maciel and Zach Arend <!-- CHANGELOG SPLIT MARKER --> ### [`v15.1.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1516-fluorite-floss-2023-02-22) [Compare Source](angular/components@15.1.5...15.1.6) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [248c41221](angular/components@248c412) | fix | **dialog:** not emitting closed event on external detachments ([#​26608](angular/components#26608)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [277f65a0f](angular/components@277f65a) | fix | **tabs:** disablePagination not working ([#​26647](angular/components#26647)) | #### Special Thanks Joey Perrott and Kristiyan Kostadinov <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDkuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OS4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1792 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the CDK dialog wasn't emitting to the
closedevent when it is detached externally, e.g. by a scroll strategy or a navigation. We had unit tests for this on the Material side, but we had special logic to handle it there.Fixes #26581.