Skip to content

refactor(material/progress-bar): change mat-progress-bar to use MDC's… #26643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
angular-robot merged 1 commit into from
Mar 22, 2023
Merged

refactor(material/progress-bar): change mat-progress-bar to use MDC's… #26643

angular-robot merged 1 commit into from
Mar 22, 2023

Conversation

@wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Feb 17, 2023

… token API

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 17, 2023
@wagnermaciel wagnermaciel force-pushed the mdc-progress-bar-theme branch 2 times, most recently from 7a72112 to f876055 Compare February 23, 2023 17:07
mmalerba
mmalerba reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see _progress-bar-theme.scss in this PR

@wagnermaciel wagnermaciel force-pushed the mdc-progress-bar-theme branch from f876055 to 6a6207a Compare March 9, 2023 20:55
@wagnermaciel
Copy link
Contributor Author

wagnermaciel commented Mar 10, 2023

@mmalerba I wasn't able to get the svg background-image to inherit the fill color even after setting it currentColor. Because of this, I went with a similar solution to our old implementation, which involves calling theme-styles in _progress-bar-theme.scss. I know this is not great, so I added to the comment to briefly mention why we cannot work around this by creating our own token slot

components/src/material/progress-bar/_progress-bar-theme.scss

Lines 12 to 13 in f2fbd9e

// We also can't set the `track-color` by creating our own token slot because the track-color
// is set in the SVG string in `theme-styles`.

mmalerba
mmalerba approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel force-pushed the mdc-progress-bar-theme branch 3 times, most recently from 27fb767 to f09cd1b Compare March 19, 2023 00:18
@wagnermaciel wagnermaciel force-pushed the mdc-progress-bar-theme branch from f09cd1b to 98cdcba Compare March 20, 2023 14:27
@angular-robot angular-robot bot merged commit 04deba8 into angular:main Mar 22, 2023
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 23, 2023
@wagnermaciel
Revert "refactor(material/progress-bar): change mat-progress-bar to u…
8981862 
…se MDC's token API (angular#26643)"

This reverts commit 04deba8.
@wagnermaciel wagnermaciel mentioned this pull request Mar 23, 2023
Merged
angular-robot bot pushed a commit that referenced this pull request Mar 23, 2023
@wagnermaciel
Revert "refactor(material/progress-bar): change mat-progress-bar to u…
69f8c3c 
…se MDC's token API (#26643)" (#26829)

This reverts commit 04deba8.
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 28, 2023
@wagnermaciel
refactor(material/progress-bar): change mat-progress-bar to use MDC's…
03729c2 
… token API (angular#26643)
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 28, 2023
@wagnermaciel
fixup! refactor(material/progress-bar): change mat-progress-bar to us…
11bde48 
…e MDC's token API (angular#26643)
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 28, 2023
@wagnermaciel
refactor(material/progress-bar): change mat-progress-bar to use MDC's…
278a912 
… token API (angular#26643)
@wagnermaciel wagnermaciel mentioned this pull request Mar 28, 2023
Merged
wagnermaciel added a commit to wagnermaciel/components that referenced this pull request Mar 29, 2023
@wagnermaciel
fixup! refactor(material/progress-bar): change mat-progress-bar to us…
25ef883 
…e MDC's token API (angular#26643)
angular-robot bot pushed a commit that referenced this pull request Mar 29, 2023
@wagnermaciel
refactor(material/progress-bar): change mat-progress-bar to use MDC's… (
3aaabbd 
#26850)

* refactor(material/progress-bar): change mat-progress-bar to use MDC's token API (#26643)

* fixup! refactor(material/progress-bar): change mat-progress-bar to use MDC's token API (#26643)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 22, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wagnermaciel @mmalerba