fix(material/chips): remove spans from top level of component #26689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `div` instead of `span` for the top-level chip wrappers since some a11y tools flag nesting `div` inside of `span` as invalid.
crisbeto
added
P3
devversion
approved these changes
Feb 24, 2023
zarend
approved these changes
Feb 24, 2023
crisbeto
added a commit
that referenced
this pull request
Feb 27, 2023
Uses `div` instead of `span` for the top-level chip wrappers since some a11y tools flag nesting `div` inside of `span` as invalid. (cherry picked from commit 94e6c94)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 3, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.0` -> `15.2.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.0/15.2.1) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.0` -> `15.2.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.0/15.2.1) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.2.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1521-silicone-soliloquy-2023-03-01) [Compare Source](angular/components@15.2.0...15.2.1) #### Breaking Changes ##### - the description for body-1 and body-2 has changed ##### material | Commit | Type | Description | | -- | -- | -- | | [9a57674fea](angular/components@9a57674) | fix | **chips:** allow attribute selectors for chips ([#​26683](angular/components#26683)) | | [fdf1dc4b07](angular/components@fdf1dc4) | fix | **chips:** chips should assume their minimum density rather than error for small densities ([#​26688](angular/components#26688)) | | [d61443b62d](angular/components@d61443b) | fix | **chips:** remove spans from top level of component ([#​26689](angular/components#26689)) | | [5e67c1a345](angular/components@5e67c1a) | fix | **chips:** styling not updating when actions are removed ([#​26696](angular/components#26696)) | | [a87735e4ba](angular/components@a87735e) | fix | **list:** add disabled attribute for mat-list-item buttons ([#​26672](angular/components#26672)) | | [54d157f3d2](angular/components@54d157f) | fix | **schematics:** migrate to mdc components selectively bug ([#​26427](angular/components#26427)) | | [4338e5ee57](angular/components@4338e5e) | fix | **snack-bar:** misaligned lines on safari for long messages ([#​26692](angular/components#26692)) | ##### | Commit | Type | Description | | -- | -- | -- | | [b71fa77f7d](angular/components@b71fa77) | docs | reverse body-1 and body-2 typography description ([#​26330](angular/components#26330)) | #### Special Thanks Hamza jayri, Kristiyan Kostadinov, Matthieu Riegler, Miles Malerba, OneSidedPrism, VICTORIA JOHNSON and llorenspujol <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE1NC4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1800 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
divinstead ofspanfor the top-level chip wrappers since some a11y tools flag nestingdivinside ofspanas invalid.