-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update angular shared dev-infra code #26699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We could cherry-pick the v16 update to the 15.2.x branch as well, as long as it doesn't affect the peer dependency in the package.json that is published to npm (I don't think it does). I'm also okay with just merging this change, but I could imagine it coming up again. |
907300e to
b9ed89f
Compare
|
@crisbeto Updated to cherry-pick v16 update, so the dev-infra update just applies cleanly (and future updates 👍 ) |
|
hmm. I think we would use this version of Angular for the partial compilation output. I don't fully recall how this would affect our compatibility, but as long as partial compilation output is still backwards compatible (which seems to be the case), we should be good. Also the partial compilation output has a |
|
I've discussed with Alan as well a bit. Capturing the conclusion here: It's more correct to not update v16 in the patch branch. Positives:
Downsides
Long-term solution would be to run Renovate on both |
b9ed89f to
907300e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
It conflicted because we updated to v16 in
mainbut not in15.2.x. Ideally the update would land in patch too, to avoid such conflicts, but that's a discussion where we never got a good conclusion on.In framework I think we are updating devkit/AIO deps also for the patch branch, always following the
@nextNPM tag. Any thoughts here @crisbeto? (notice how dev-infra already uses v16 too- so we have a mismatch now)