Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): fix opacity in elevation mixin #26805

Merged
merged 2 commits into from
May 4, 2023
Merged

fix(material/core): fix opacity in elevation mixin #26805

merged 2 commits into from
May 4, 2023

Conversation

skrtheboss
Copy link
Contributor

Fix elevation opacity, which was reintroduced by 951759e.

@google-cla
Copy link

google-cla bot commented Mar 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@andrewseguin andrewseguin requested a review from crisbeto March 17, 2023 13:17
@skrtheboss skrtheboss force-pushed the fix-elevation-opacity branch from 922abb6 to f4f9661 Compare March 17, 2023 13:20
@pavankjadda
Copy link

@crisbeto @andrewseguin Any update on this. I tested my apps with v16, I see this issue. This is a blocker for to upgrade to v16 when it releases next month.

crisbeto
crisbeto approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/material/core/style/_elevation.scss Outdated Show resolved Hide resolved
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 2, 2023
@crisbeto
Copy link
Member

crisbeto commented May 2, 2023

Can you rebase to resolve the integration tests error?

@skrtheboss skrtheboss force-pushed the fix-elevation-opacity branch from f4f9661 to d39d8fd Compare May 2, 2023 10:04
@skrtheboss skrtheboss force-pushed the fix-elevation-opacity branch from 9003a1b to 31197b1 Compare May 2, 2023 14:02
@crisbeto crisbeto self-assigned this May 3, 2023
@angular-robot angular-robot bot merged commit 514c113 into angular:main May 4, 2023
angular-robot bot pushed a commit that referenced this pull request May 4, 2023
@skrtheboss @crisbeto
fix(material/core): fix opacity in elevation mixin (#26805)
5450755 
* fix(material/core): fix opacity in elevation mixin

* fixup! fix(material/core): fix opacity in elevation mixin

(cherry picked from commit 514c113)
@skrtheboss skrtheboss deleted the fix-elevation-opacity branch May 4, 2023 16:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skrtheboss @pavankjadda @crisbeto