fix(material/core): apply strong focus styles to selected option #26811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
Apply strong focus styles to the selected option. Do this by putting the `.mat-mdc-focus-indicator` class on the ripple element. Fix issue where the List styles from MDC override the strong focus style, which causes the strong focus indicator to not be present on selected option (angular#26801). Align maat-option with list-item's implementation by putting the focus indicator on a child element of the component root, rather than directly on the component root. Does not add aditional DOM nodes.
zarend
force-pushed
the
mat-option-focus-dom-node
branch
from
ef7d14f to
da54e57
Compare
zarend
added
the
dev-app preview
|
Deployed dev-app for da54e57 to: https://ng-dev-previews-comp--pr-angular-components-26811-z4zccti6.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
angular-robot bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
) Apply strong focus styles to the selected option. Do this by putting the `.mat-mdc-focus-indicator` class on the ripple element. Fix issue where the List styles from MDC override the strong focus style, which causes the strong focus indicator to not be present on selected option (#26801). Align maat-option with list-item's implementation by putting the focus indicator on a child element of the component root, rather than directly on the component root. Does not add aditional DOM nodes. (cherry picked from commit 96aadaa)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 30, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.1/15.2.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.1/15.2.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1525-metal-plumber-2023-03-29) [Compare Source](angular/components@15.2.4...15.2.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [4ec3abd723](angular/components@4ec3abd) | fix | **overlay:** don't close if scroll is coming from inside overlay ([#​26840](angular/components#26840)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [600d40eb24](angular/components@600d40e) | fix | **datepicker:** remove div as a child of button ([#​26838](angular/components#26838)) | #### Special Thanks Kristiyan Kostadinov and Wagner Maciel <!-- CHANGELOG SPLIT MARKER --> ### [`v15.2.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1524-brimstone-bank-2023-03-23) [Compare Source](angular/components@15.2.3...15.2.4) ##### material | Commit | Type | Description | | -- | -- | -- | | [580fbf500](angular/components@580fbf5) | fix | **core:** apply strong focus styles to selected option ([#​26811](angular/components#26811)) | | [1ba5ade41](angular/components@1ba5ade) | fix | **datepicker:** date range input not marked as required when using reactive forms ([#​26749](angular/components#26749)) | | [acc7d8148](angular/components@acc7d81) | fix | **tooltip:** only expand hover area on side closest to trigger ([#​26786](angular/components#26786)) | #### Special Thanks Kristiyan Kostadinov, Wagner Maciel and Zach Arend <!-- CHANGELOG SPLIT MARKER --> ### [`v15.2.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1523-aluminum-statue-2023-03-16) [Compare Source](angular/components@15.2.2...15.2.3) ##### material | Commit | Type | Description | | -- | -- | -- | | [7dfcf8ff3](angular/components@7dfcf8f) | fix | **checkbox:** fix ARIA semantics and use native DOM properties ([#​26710](angular/components#26710)) | | [40d38889c](angular/components@40d3888) | fix | **chips:** chip label appearing above sticky columns ([#​26794](angular/components#26794)) | | [b846d1e05](angular/components@b846d1e) | fix | **chips:** don't prevent default mousedown action ([#​26765](angular/components#26765)) | | [501d73e5b](angular/components@501d73e) | fix | **chips:** styling not cleared on basic chips in listbox and grid ([#​26771](angular/components#26771)) | | [06ed54c25](angular/components@06ed54c) | fix | **tabs:** update MatTab \_scrollToLabel function to always display a label from its start ([#​26736](angular/components#26736)) ([#​26737](angular/components#26737)) | #### Special Thanks Boyi Li, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend <!-- CHANGELOG SPLIT MARKER --> ### [`v15.2.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1522-topaz-toast-2023-03-08) [Compare Source](angular/components@15.2.1...15.2.2) ##### material | Commit | Type | Description | | -- | -- | -- | | [e7612c747](angular/components@e7612c7) | fix | **chips:** unable to shift + tab out of a chip set ([#​26727](angular/components#26727)) | | [1bf2fc2e1](angular/components@1bf2fc2) | fix | **core:** mat-option sets aria-selected="false" ([#​26673](angular/components#26673)) | | [9473b1688](angular/components@9473b16) | fix | **datepicker:** resolve server-side rendering error ([#​26742](angular/components#26742)) | | [99dac0835](angular/components@99dac08) | fix | **paginator:** opt-out of single-selection indicator ([#​26746](angular/components#26746)) | | [ec824f1f7](angular/components@ec824f1) | fix | **snack-bar:** live region not working when modal is open ([#​26725](angular/components#26725)) | ##### cdk-experimental | Commit | Type | Description | | -- | -- | -- | | [e1c8fe85b](angular/components@e1c8fe8) | fix | **scrolling:** throw error rather than string ([#​26736](angular/components#26736)) | #### Special Thanks Kristiyan Kostadinov, RuoJia123 and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMSIsInVwZGF0ZWRJblZlciI6IjM1LjI0LjYifQ==--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1813 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply strong focus styles to the selected option. Do this by putting the
.mat-mdc-focus-indicatorclass on the ripple element.Fix issue where the List styles from MDC override the strong focus style, which causes the strong focus indicator to not be present on selected option (#26801).
Align maat-option with list-item's implementation by putting the focus indicator on a child element of the component root, rather than directly on the component root.
Does not add aditional DOM nodes.