Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tabs): remove background color from tabs #26905

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

crisbeto
Copy link
Member

Resolves a recent regression where tabs no longer have a background: none which can cause them to be grey when used on a <button> element.

Resolves a recent regression where tabs no longer have a `background: none` which can cause them to be grey when used on a `<button>` element.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Apr 11, 2023
@crisbeto crisbeto requested a review from andrewseguin April 11, 2023 07:22
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 11, 2023
@angular-robot angular-robot bot merged commit 26a4651 into angular:main Apr 11, 2023
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 14, 2023
Resolves a recent regression where tabs no longer have a `background: none` which can cause them to be grey when used on a `<button>` element.
angular-robot bot pushed a commit that referenced this pull request Apr 14, 2023
* refactor(material/tabs): switch to tokens API (#26881)

Switches the tabs to use the new tokens API.

* refactor(material/tabs): introduce new tokens (#26901)

Adds new tokens to the tabs to make it easier to implement the gmat variant.

* build: update ng add standalone integration test (#26894)

The layout for a standalone project has changed since we added our integration test.

* fix(material/tabs): remove background color from tabs (#26905)

Resolves a recent regression where tabs no longer have a `background: none` which can cause them to be grey when used on a `<button>` element.

* fix(cdk/layout): resolve CSP errors

The `MediaMatcher` needs to insert a `style` tag in some cases. These changes use the new `CSP_NONCE` token to avoid these issues.

* fix(cdk-experimental/table-scroll-container): avoid CSP errors

Adds a nonce to the `style` tag generated by the table scroll container to avoid CSP errors.

* fix(cdk-experimental/column-resize): avoid CSP errors

Uses the new `CSP_NONCE` token to avoid errors when inserting `style` tags dynamically in the column resize package.

* fix(material/legacy-progress-spinner): avoid CSP errors

Uses the new `CSP_NONCE` injection token to avoid errors when inserting a `style` tag dynamically for the spinner animation.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Apr 14, 2023
Resolves a recent regression where tabs no longer have a `background: none` which can cause them to be grey when used on a `<button>` element.
angular-robot bot pushed a commit that referenced this pull request Apr 14, 2023
Resolves a recent regression where tabs no longer have a `background: none` which can cause them to be grey when used on a `<button>` element.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants