Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/core): remove tabindex from mat-option #26917

Merged
merged 1 commit into from
Apr 14, 2023

Commits on Apr 13, 2023

  1. fix(material/core): remove tabindex from mat-option

    Remove the tabindex attribute added to MatOption components. MatOption
    does not need tabindex because the parent component manages focus by
    setting `aria-activedescendant` attribute. Previously, MatOption set
    tabindex but was also a referenced by aria-activedescendant. This was
    not the correct ARIA semantics. Align closer to ARIA spec by using only
    aria-activedescendant rather than both.
    
    Tabindex="-1" seems to be causing a problem in angular#26861 where VoiceOver
    with Firefox moves DOM focus from the combobox to the option when
    opening the listbox popup.
    
    Unblocks angular#26861.
    zarend committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    cdcec28 View commit details
    Browse the repository at this point in the history