fix(material/chips): fix chip density styles #26951
Conversation
wagnermaciel
commented
Apr 18, 2023
wagnermaciel
commented
- Chip density styles were not being applied properly because of specificity issues - Stackblitz example
wagnermaciel
requested review from
mmalerba,
crisbeto and
zarend
as code owners
src/material/chips/_chips-theme.scss
Outdated
| @@ -94,7 +94,8 @@ | |||
| @mixin density($config-or-theme) { | |||
| $density-scale: theming.get-density-config($config-or-theme); | |||
| $density-scale: theming.clamp-density($density-scale, -2); | |||
| .mat-mdc-chip { | |||
| .mat-mdc-chip, | |||
| .mat-mdc-standard-chip.mat-mdc-standard-chip { | |||
There was a problem hiding this comment.
Doesn't mat-mdc-chip already target mat-mdc-standard-chip?
There was a problem hiding this comment.
I think so. Should I just use .mat-mdc-chip.mat-mdc-chip instead?
There was a problem hiding this comment.
Yeah I think that should be enough.
There was a problem hiding this comment.
Ah sorry, I replied too quickly. I think it should be .mat-mdc-chip.mat-mdc-standard-chip. The basic chips don't have any styles AFAIK.
There was a problem hiding this comment.
Do you mean they aren't meant to have any styles? Currently in our dev-app, they are receiving density styles because we target .mat-mdc-chip instead of .mat-mdc-standard-chip
There was a problem hiding this comment.
I think that technically they aren't supposed to have any styles.
wagnermaciel
added
action: merge
* fix(material/chips): fix chip density styles * fixup! fix(material/chips): fix chip density styles * fixup! fix(material/chips): fix chip density styles (cherry picked from commit cffc93b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
