-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/portal): remove ComponentFactoryResolver usages #27427
Conversation
f83b846
to
9311712
Compare
56a3230
to
d31b549
Compare
This one is blocked, because it caused some subtle DI behavior differences in g3 which break some tests. |
I'm currently using this in a module federation setup in combination with ngx-translate. However, when i explicitly add the componentFactoryResolver, my translations are loaded from my child project as it should in this case. ie. the component is rendered as if it was fully in my child project. From how i just read these changes, it would seem that viewContainerRef should be sufficient to achieve the same? Is that correct? |
@crisbeto any updates on this one? |
Any update on this? |
Can you please share the current state? |
We now have all the necessary APIs to allow to remove our usages of the deprecated `ComponentFactoryResolver`. Fixes angular#24334.
d31b549
to
f7d0b80
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We now have all the necessary APIs to allow to remove our usages of the deprecated
ComponentFactoryResolver
.Fixes #24334.