Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/collections): SelectionModel setSelection method inconsistent… #27460

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

iladovi
Copy link
Contributor

@iladovi iladovi commented Jul 14, 2023

… with compareWith

Fix bug in SelectionModel where compareWith function was not consistently respected in setSelection method.

Fixes #27425

… with compareWith

Fix bug in SelectionModel where compareWith function
was not consistently respected in setSelection method.

Fixes angular#27425
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 20, 2025
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Feb 20, 2025
@mmalerba mmalerba self-assigned this Feb 20, 2025
@mmalerba mmalerba merged commit 9494ff2 into angular:main Feb 20, 2025
22 of 24 checks passed
@mmalerba
Copy link
Contributor

The changes were merged into the following branches: main, 19.1.x, 19.2.x

mmalerba pushed a commit that referenced this pull request Feb 20, 2025
… with compareWith (#27460)

Fix bug in SelectionModel where compareWith function
was not consistently respected in setSelection method.

Fixes #27425

(cherry picked from commit 9494ff2)
mmalerba pushed a commit that referenced this pull request Feb 20, 2025
… with compareWith (#27460)

Fix bug in SelectionModel where compareWith function
was not consistently respected in setSelection method.

Fixes #27425

(cherry picked from commit 9494ff2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/collections target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(selection-model): setSelection in SelectionModel does not respect compareWith
2 participants