Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/menu): nested menus requiring two taps to open touch devices #27586

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix(cdk/menu): nested menus requiring two taps to open touch devices #27586

merged 1 commit into from
Aug 7, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 5, 2023

The CDK menu supports opening a nested menu by hover, but the problem is that touch devices dispatch fake mouseenter events which end up closing the menu immediately. These changes add some logic to ignore such events.

Fixes #27508.

@crisbeto
fix(cdk/menu): nested menus requiring two taps to open touch devices
7bbd3f1 
The CDK menu supports opening a nested menu by hover, but the problem is that touch devices dispatch fake `mouseenter` events which end up closing the menu immediately. These changes add some logic to ignore such events.

Fixes angular#27508.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 5, 2023
@crisbeto crisbeto requested a review from andrewseguin August 5, 2023 07:29
@crisbeto crisbeto requested a review from mmalerba as a code owner August 5, 2023 07:29
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2023
@crisbeto crisbeto self-assigned this Aug 7, 2023
@crisbeto crisbeto merged commit d190e87 into angular:main Aug 7, 2023
crisbeto added a commit that referenced this pull request Aug 7, 2023
@crisbeto
fix(cdk/menu): nested menus requiring two taps to open touch devices (#…
95392a6 
…27586)

The CDK menu supports opening a nested menu by hover, but the problem is that touch devices dispatch fake `mouseenter` events which end up closing the menu immediately. These changes add some logic to ignore such events.

Fixes #27508.

(cherry picked from commit d190e87)
crisbeto added a commit that referenced this pull request Aug 7, 2023
@crisbeto
fix(cdk/menu): nested menus requiring two taps to open touch devices (#…
3284407 
…27586)

The CDK menu supports opening a nested menu by hover, but the problem is that touch devices dispatch fake `mouseenter` events which end up closing the menu immediately. These changes add some logic to ignore such events.

Fixes #27508.

(cherry picked from commit d190e87)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(CdkMenu): Opening submenu requires two clicks on touch display (Chrome)
2 participants
@crisbeto @andrewseguin