-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/drag-drop): constrainPosition now working well with boundary #27730
fix(cdk/drag-drop): constrainPosition now working well with boundary #27730
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the test. It looks like there are a couple of lint failures as well.
aac2232
to
26a87c2
Compare
26a87c2
to
487d2f2
Compare
@crisbeto Do you need anything else from me? Should I squash the commits and make sure the commit message follows the guidelines, or how does that happen? |
It's okay, I'll squash the commits when I merge it in. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Initial attempt at a fix for #25154