-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/overlay): fix overlay margin in isBoundedByLeftViewportEdge #28233
Conversation
…'left-ward') mode
I'm not sure if this is the desired behavior? It's been a long time since I wrote this, but I think that we'd want to keep it such that the rightmost edge of the bounding box is the actual viewport edge minus one margin, no? |
and also the same behavior is implemented when calculating the bottom line 772 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, understood
.. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When the overlay is opening 'left-ward' (the content flows to the left) the margin is not calculated correctly because the margin is subtracted twice from the width (line: 1092), but here it is added only once