fix(material/tabs): deprecate backgroundColor API #28262
Conversation
andrewseguin
added
the
target: patch
src/material/tabs/tab-group.ts
Outdated
| @Input() | ||
| get backgroundColor(): ThemePalette { | ||
| return this._backgroundColor; | ||
| } | ||
|
|
||
| set backgroundColor(value: ThemePalette) { | ||
| const classList: DOMTokenList = this._elementRef.nativeElement.classList; | ||
| if (ENABLE_BACKGROUND_INPUT) { |
There was a problem hiding this comment.
nit: maybe we should log a warning here if it's disabled so that internal users don't wonder why it does nothing?
There was a problem hiding this comment.
Totally - in fact I'd take this one step further and throw an Error to say it's not a valid input. I wish it was namespaced more specifically just in case it's used by a sibling directive, but I don't expect that to be likely.
There was a problem hiding this comment.
The Error will help perform a migration to catch all usages before we disable it
andrewseguin
force-pushed
the
tabs-background-api
branch
from
5d8fc8b
to
3891451
Compare
andrewseguin
force-pushed
the
tabs-background-api
branch
from
3891451
to
78e891c
Compare
andrewseguin
requested review from
devversion and
josephperrott
as code owners
(cherry picked from commit 771f1df)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Tabs background colors should be customized using the theming API instead of using component inputs. Adding a boolean check that can be modified internally to perform cleanup before v20.