fix(material/schematics): schema error in mdc migration #28342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[A recent change in the CLI](angular/angular-cli#26685) added a `-d` flag to `ng generate` which is the same as the alias for `--directory` in the MDC migration. This caused an error, because the default boolean value from the CLI was being picked up and was failing the schema validation. These changes remove the alias since it isn't really necessary. Fixes angular#28335.
crisbeto
added
P2
devversion
approved these changes
Dec 30, 2023
crisbeto
added a commit
that referenced
this pull request
Dec 31, 2023
[A recent change in the CLI](angular/angular-cli#26685) added a `-d` flag to `ng generate` which is the same as the alias for `--directory` in the MDC migration. This caused an error, because the default boolean value from the CLI was being picked up and was failing the schema validation. These changes remove the alias since it isn't really necessary. Fixes #28335. (cherry picked from commit b9450c9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in the CLI added a
-dflag tong generatewhich is the same as the alias for--directoryin the MDC migration. This caused an error, because the default boolean value from the CLI was being picked up and was failing the schema validation.These changes remove the alias since it isn't really necessary.
Fixes #28335.