Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 5, 2024

Sets up the tokens for the M3 buttons.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 5, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jan 5, 2024
@function icon-button($systems, $exclude-hardcoded) {
@return (
state-layer-color: map.get($systems, md-sys-color, on-surface-variant),
disabled-state-layer-color: map.get($systems, md-sys-color, on-surface-variant),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change. I noticed that we weren't emitting this token.

Sets up the tokens for the M3 buttons.
@mmalerba mmalerba added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Jan 8, 2024
@github-actions
Copy link

github-actions bot commented Jan 8, 2024

Deployed dev-app for 47200d3 to: https://ng-dev-previews-comp--pr-angular-components-28375-dev-x50vbv21.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto self-assigned this Jan 9, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release labels Jan 9, 2024
@crisbeto crisbeto merged commit 244bed4 into angular:main Jan 9, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants