Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/autocomplete): requireSelection sometimes not clearing value when editing after selection #28628

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

crisbeto
Copy link
Member

Fixes that if the user has requireSelection enabled, selects a value and then deletes a character while the input still has a value, the selection wasn't being cleared as expected.

Fixes #28432.

…alue when editing after selection

Fixes that if the user has `requireSelection` enabled, selects a value and then deletes a character while the input still has a value, the selection wasn't being cleared as expected.

Fixes angular#28432.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 22, 2024
@crisbeto crisbeto self-assigned this Feb 22, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 22, 2024
@crisbeto crisbeto merged commit 216ae0c into angular:main Feb 22, 2024
25 of 27 checks passed
crisbeto added a commit that referenced this pull request Feb 22, 2024
…alue when editing after selection (#28628)

Fixes that if the user has `requireSelection` enabled, selects a value and then deletes a character while the input still has a value, the selection wasn't being cleared as expected.

Fixes #28432.

(cherry picked from commit 216ae0c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Autocomplete): requireSelection Fails After Selection & Value Change
2 participants