Skip to content

refactor(material/form-field): Remove use of zone onStable to schedule outline updates #28636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmalerba merged 1 commit into from
Mar 20, 2024
Merged

refactor(material/form-field): Remove use of zone onStable to schedule outline updates #28636

mmalerba merged 1 commit into from
Mar 20, 2024

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 23, 2024 •
edited
Loading

Depends on moving overlay off of NgZone.onStable first (passing TGP after that)

AndrewKushnir
AndrewKushnir reviewed Feb 23, 2024
View reviewed changes
@mmalerba mmalerba force-pushed the ff-zone branch 7 times, most recently from b0604f0 to 0b858ad Compare February 26, 2024 19:17
@mmalerba mmalerba changed the title refactor(material/form-field): use afterNextRender to schedule outline updates refactor(material/form-field): use afterRender to schedule outline updates Feb 26, 2024
@mmalerba mmalerba changed the title refactor(material/form-field): use afterRender to schedule outline updates refactor(material/form-field): Remove use of zone onStable to schedule outline updates Feb 26, 2024
@mmalerba mmalerba added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Feb 27, 2024
@mmalerba mmalerba added target: major This PR is targeted for the next major release and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Mar 8, 2024
@mmalerba mmalerba marked this pull request as ready for review March 8, 2024 21:26
@mmalerba mmalerba requested a review from devversion as a code owner March 8, 2024 21:26
@mmalerba mmalerba added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Mar 17, 2024
@devversion devversion removed their request for review March 19, 2024 11:57
@mmalerba mmalerba removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Mar 19, 2024
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 20, 2024
@mmalerba mmalerba merged commit 950d125 into angular:main Mar 20, 2024
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 20, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir left review comments

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @andrewseguin @AndrewKushnir