fix(material/tree): aria-expanded attribute should not appear in the leaf node #29096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
reviewed
Jun 7, 2024
fixed unit tests Fixes angular#21922
updated public api file Fixes angular#21922
andrewseguin
approved these changes
Jun 17, 2024
andrewseguin
added
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jun 17, 2024
andrewseguin
added a commit
to andrewseguin/components
that referenced
this pull request
Jun 17, 2024
… in the leaf node (angular#29096)" This reverts commit 43b8dcb.
andrewseguin
added a commit
that referenced
this pull request
Jun 17, 2024
DBowen33
added a commit
to DBowen33/components
that referenced
this pull request
Jul 3, 2024
…leaf node (angular#29096) * fix(material/tree): fixed unit tests fixed unit tests Fixes angular#21922 * fix(material/tree): updated public api file updated public api file Fixes angular#21922
This was referenced Jul 12, 2024
DBowen33
added a commit
to DBowen33/components
that referenced
this pull request
Jul 12, 2024
…leaf node (angular#29096) * fix(material/tree): fixed unit tests fixed unit tests Fixes angular#21922 * fix(material/tree): updated public api file updated public api file Fixes angular#21922
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue to where leaf nodes were wrongly being assigned the aria-expanded attribute, which could confuse screen reader users.
https://screencast.googleplex.com/cast/NjMzNDkwNjM4MzcyODY0MHxkMTY5ZTdkNC05Mw
Fixes #21922
Fixes #21143