fix(material/slider): Tick marks changes position as the slider is changed (for a step that is decimal number) #29108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged (for a step that is decimal number) Fixes the bug in the Angular Material 'slider' component. Changed the function in the calculation from .floor to .round Due to floating-point precision in JavaScript. (1 - 0.9) / 0.1 evaluates to 0.9999999999999999 Even though mathematically it should be 1 The calculation in the code resulted in slightly smaller value. Math.floor(0.9999999999999999) evaluates to 0. Math.round(0.9999999999999999) evaluates to 1. Fixes angular#29084
crisbeto
approved these changes
May 29, 2024
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
May 30, 2024
…anged (for a step that is decimal number) (#29108) Fixes the bug in the Angular Material 'slider' component. Changed the function in the calculation from .floor to .round Due to floating-point precision in JavaScript. (1 - 0.9) / 0.1 evaluates to 0.9999999999999999 Even though mathematically it should be 1 The calculation in the code resulted in slightly smaller value. Math.floor(0.9999999999999999) evaluates to 0. Math.round(0.9999999999999999) evaluates to 1. Fixes #29084 (cherry picked from commit 3314414)
|
Hey can this change be merged into v17 as well please? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug in the Angular Material 'slider' component.
Changed the function in the calculation from .floor to .round
Due to floating-point precision in JavaScript. (1 - 0.9) / 0.1 evaluates to 0.9999999999999999
Even though mathematically it should be 1
The calculation in the code resulted in slightly smaller value.
Math.floor(0.9999999999999999) evaluates to 0.
Math.round(0.9999999999999999) evaluates to 1.
Fixes #29084