build: broaden ownership to team #29199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
| /goldens/** @andrewseguin @mmalerba @crisbeto | ||
| /src/* @devversion @josephperrott | ||
| /* @devversion @josephperrott | ||
| * @angular/components-googlers |
Member
There was a problem hiding this comment.
I think you actually need to have the base directories you want to include here.
* would just refer to the files at the root of the repository
** would be everything in the repo, but that would include the other files I believe.
Contributor
Author
There was a problem hiding this comment.
I think * might be a special case, cause I do see that something like dir/* only covers immediate folder files (not nested). Here's what their docs say
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
# @global-owner1 and @global-owner2 will be requested for
# review when someone opens a pull request.
* @global-owner1 @global-owner2
josephperrott
approved these changes
Jun 5, 2024
| /goldens/** @andrewseguin @mmalerba @crisbeto | ||
| /src/* @devversion @josephperrott | ||
| /* @devversion @josephperrott | ||
| * @angular/components-googlers |
andrewseguin
added
target: patch
andrewseguin
added a commit
that referenced
this pull request
Jun 6, 2024
(cherry picked from commit 6cf7f54)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigned ownership per component made more sense in the early days when we each had fully authored components