Skip to content

build: update to TypeScript 5.5 #29217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crisbeto merged 1 commit into from
Jun 10, 2024
Merged

build: update to TypeScript 5.5 #29217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,034 changes: 1,027 additions & 1,007 deletions integration/harness-e2e-cli/yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions integration/ng-add-standalone/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ node_integration_test(
"rm -f %s/package.json" % APP_NAME,
# Delete the Karma config since we need to use a headless browser.
"rm -f %s/karma.conf.js" % APP_NAME,
# Delete the tsconfig since we have a pre-defined one.
"rm -f %s/tsconfig.json" % APP_NAME,
# We can't name the checked-in config `angular.json`, because the CLI doesn't allow
# `ng new` to run in a directory that has an `angular.json` already.
"mv _angular.json angular.json",
Expand Down
2 changes: 1 addition & 1 deletion integration/ng-add-standalone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.0.0",
"typescript": "~5.4.2"
"typescript": "5.5.1-rc"
}
}
28 changes: 28 additions & 0 deletions integration/ng-add-standalone/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
Copy link
Member

@devversion devversion Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we add these configs? (out of curiosity)

Copy link
Member Author

@crisbeto crisbeto Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the test apps stopped compiling because they couldn't find tslib. I couldn't track it down and assumed it was some Bazel issue so I ended up setting importHelpers: false.

"compileOnSave": false,
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist/out-tsc",
"forceConsistentCasingInFileNames": true,
"strict": true,
"noImplicitOverride": true,
"noPropertyAccessFromIndexSignature": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"sourceMap": true,
"declaration": false,
"downlevelIteration": true,
"experimentalDecorators": true,
"moduleResolution": "node",
"importHelpers": false,
"target": "es2017",
"module": "es2020",
"lib": ["es2020", "dom"]
},
"angularCompilerOptions": {
"enableI18nLegacyMessageIdFormat": false,
"strictInjectionParameters": true,
"strictInputAccessModifiers": true,
"strictTemplates": true
}
}
Loading