Skip to content

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jun 17, 2024

The tools/ directory was previously missing which caused red squigglies when we tried to import from the tools directory. e.g., in our theming tests: import {createLocalAngularPackageImporter} from '../../../../../tools/sass/local-sass-importer';

@mmalerba mmalerba marked this pull request as ready for review June 17, 2024 23:17
@mmalerba mmalerba requested a review from a team as a code owner June 17, 2024 23:17
@mmalerba mmalerba requested review from crisbeto and removed request for a team June 17, 2024 23:17
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 17, 2024
@mmalerba mmalerba changed the title lint: fix rootDir build: fix rootDir Jun 17, 2024
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jun 17, 2024
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 18, 2024
@mmalerba mmalerba merged commit 6e8804d into angular:main Jun 18, 2024
mmalerba added a commit that referenced this pull request Jun 18, 2024
(cherry picked from commit 6e8804d)
DBowen33 pushed a commit to DBowen33/components that referenced this pull request Jul 3, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants