fix(material/core): add fallback if ripples get stuck #29323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto and
mmalerba
and removed request for
a team
Currently ripples assume that after the transition is started, either a `transitionend` or `transitioncancel` event will occur. That doesn't seem to be the case in some browser/OS combinations and when there's a high load on the browser. These changes add a fallback timer that will clear the ripples if they get stuck. Fixes angular#29159.
crisbeto
force-pushed
the
29159/stuck-ripples
branch
from
c09194f to
73f2fa3
Compare
mmalerba
approved these changes
Jun 26, 2024
crisbeto
added a commit
that referenced
this pull request
Jun 27, 2024
Currently ripples assume that after the transition is started, either a `transitionend` or `transitioncancel` event will occur. That doesn't seem to be the case in some browser/OS combinations and when there's a high load on the browser. These changes add a fallback timer that will clear the ripples if they get stuck. Fixes #29159. (cherry picked from commit 674538b)
essjay05
pushed a commit
to essjay05/angular-components
that referenced
this pull request
Jun 27, 2024
Currently ripples assume that after the transition is started, either a `transitionend` or `transitioncancel` event will occur. That doesn't seem to be the case in some browser/OS combinations and when there's a high load on the browser. These changes add a fallback timer that will clear the ripples if they get stuck. Fixes angular#29159.
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 3, 2024
Currently ripples assume that after the transition is started, either a `transitionend` or `transitioncancel` event will occur. That doesn't seem to be the case in some browser/OS combinations and when there's a high load on the browser. These changes add a fallback timer that will clear the ripples if they get stuck. Fixes angular#29159.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ripples assume that after the transition is started, either a
transitionendortransitioncancelevent will occur. That doesn't seem to be the case in some browser/OS combinations and when there's a high load on the browser.These changes add a fallback timer that will clear the ripples if they get stuck.
Fixes #29159.