feat(material/schematics): Switch custom theme schematic to use theme mixin instead of define-theme and add high contrast override mixins #29642
Conversation
amysorto
added
Accessibility
amysorto
force-pushed
the
high-contrast-define-theme-schematic
branch
from
2d7fe98 to
0514fcc
Compare
| ): DynamicScheme { | ||
| return new DynamicScheme({ | ||
| sourceColorArgb: primaryPalette.keyColor.toInt(), | ||
| variant: 6, // Variant enum is not accessible outside of @material/material-color-utilities |
There was a problem hiding this comment.
What is "6"? Should include this in comments
There was a problem hiding this comment.
Updated the comment, variant is supposed to take a Variant enum but it isn't exposed outside the package
amysorto
force-pushed
the
high-contrast-define-theme-schematic
branch
from
0514fcc to
aa3ef13
Compare
There was a problem hiding this comment.
I think we can remove the m3 prefix from this schematic. Also I wonder if another name makes more sense now that it isn't creating a config. Maybe theme-color or just color
Let's also wait on merging this pull request until the theme mixin is renamed
There was a problem hiding this comment.
The first sentence of the README says it makes theme configurations - let's reword that to say it makes theme colors
There was a problem hiding this comment.
I renamed it to palettes since that's what users are importing from the generated file
amysorto
force-pushed
the
high-contrast-define-theme-schematic
branch
2 times, most recently
from
84cdc16 to
a3cbcfc
Compare
|
I renamed the schematic to |
amysorto
force-pushed
the
high-contrast-define-theme-schematic
branch
2 times, most recently
from
1067ecd to
0ff4ba3
Compare
guides/theming.md
Outdated
| // Apply the light theme by default | ||
| @include mat.core-theme(m3-theme.$light-theme); | ||
| @include mat.button-theme(m3-theme.$light-theme); | ||
| @include mat.private-experimental-theme( |
|
Yeah we should rename the file. Maybe just |
… mixin instead of define-theme and add high contrast override mixins
amysorto
force-pushed
the
high-contrast-define-theme-schematic
branch
from
0ff4ba3 to
7d62958
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
No description provided.