Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/badge): resolve memory leak #29676

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 2, 2024

The badge had an extra unnecessary check which meant that it would sometimes leak memory through the style loader. This isn't a big deal on the client since there's usually only one app on the page, but it can be a problem on the server which can create and destroy an app for each request.

Note that this is no longer an issue in 19.x where we use the common style loader, but we need to backport the fix to 18.x.

Fixes angular/angular#57529.

The badge had an extra unnecessary check which meant that it would sometimes leak memory through the style loader. This isn't a big deal on the client since there's usually only one app on the page, but it can be a problem on the server which can create and destroy an app for each request.

Note that this is no longer an issue in 19.x where we use the common style loader, but we need to backport the fix to 18.x.

Fixes angular/angular#57529.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 2, 2024
@crisbeto crisbeto requested a review from a team as a code owner September 2, 2024 06:42
@crisbeto crisbeto requested review from amysorto, mmalerba and devversion and removed request for a team September 2, 2024 06:42
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 2, 2024
@crisbeto crisbeto merged commit 0f07b25 into angular:18.2.x Sep 2, 2024
23 of 25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants