Skip to content

refactor(multiple): switch material to the inject function #29731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

crisbeto
Copy link
Member

Switches Material from constructor-based DI to the inject function.

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Sep 13, 2024
@crisbeto crisbeto force-pushed the material-inject branch 5 times, most recently from 9fb556b to 3ea0dc7 Compare September 17, 2024 08:55
Switches Material from constructor-based DI to the `inject` function.
@crisbeto crisbeto marked this pull request as ready for review September 17, 2024 13:31
@crisbeto crisbeto requested a review from a team as a code owner September 17, 2024 13:31
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team September 17, 2024 13:31
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@crisbeto crisbeto removed the request for review from mmalerba September 19, 2024 08:00
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 19, 2024
@crisbeto crisbeto merged commit 5897f37 into angular:main Sep 19, 2024
25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants