-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/tabs): add alignTabs
in MatTabsConfig
#29779
Conversation
0021fc8
to
60f2556
Compare
src/material/tabs/tab-group.ts
Outdated
@@ -147,6 +148,10 @@ export class MatTabGroup implements AfterContentInit, AfterContentChecked, OnDes | |||
@Input({alias: 'mat-stretch-tabs', transform: booleanAttribute}) | |||
stretchTabs: boolean = true; | |||
|
|||
/** Alignment for tabs label. */ | |||
@Input({alias: 'mat-align-tabs'}) | |||
alignTabs: 'start' | 'center' | 'end' | null = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is the correct type, it looks like we'll have to set it to string | null
since it breaks some cases internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it but internal cases CI is still pending not sure if recent push triggered it or not.
also this is wrong place to ask but when I run yarn
after fork it keeps failing with:
[3/5] Fetching packages...
error Couldn't find match for "36946be4df61f6549ae3829c026022e47674eae2" in "refs/heads/main" for "https://github.com/angular/dev-infra-private-ng-dev-builds.git".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
my-pc@mypc-Latitude-3310:~/Development/angular-projects/open-source/components$
I tried to manually install the package in a clean folder with only @angular/ng-dev
package but it still failed I have a global setting for specific NPM packages but they only work with npm (not sure if they will collide with yarn) & also this is something that came up recently, I was able to install packages before IIRC.
align
in MatTabsConfig
alignTabs
in MatTabsConfig
users can align tabs label via config now rather than adding `mat-tab-align` property on each tab group fixes angular#29685
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
users can align tabs label via config now rather than adding
mat-tab-align
property on each tab groupfixes #29685