Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): rename sys vars from mat-app to mat-sys #29879

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(material/core): rename sys vars from mat-app to mat-sys #29879

merged 1 commit into from
Oct 17, 2024

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Oct 15, 2024
@andrewseguin andrewseguin requested a review from a team as a code owner October 15, 2024 17:36
@andrewseguin andrewseguin requested review from crisbeto and amysorto and removed request for a team October 15, 2024 17:36
crisbeto
crisbeto reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the --sys prefix in _definition.scss as well?

@andrewseguin
Copy link
Contributor Author

Probably...I can't think of any immediate reasons why that would cause any conflicts, but that code path is sorta unrelated to this mat.theme API.

If we do, itll be in a followup PR since that would cause conflicts internally

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2024
@andrewseguin andrewseguin merged commit 613cf54 into angular:main Oct 17, 2024
25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amysorto amysorto amysorto approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewseguin @crisbeto @amysorto