Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/menu): handle keyboard events through dispatcher #29997

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

crisbeto
Copy link
Member

Currently mat-menu handles it keyboard events in the template, however this ignores the overlay's stacking context which can capture some events that it shouldn't.

These changes switch the menu to handling the events through the common dispatcher instead.

Fixes #29996.

@crisbeto crisbeto added the target: rc This PR is targeted for the next release-candidate label Nov 12, 2024
@crisbeto crisbeto requested a review from a team as a code owner November 12, 2024 10:11
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team November 12, 2024 10:11
Currently `mat-menu` handles it keyboard events in the template, however this ignores the overlay's stacking context which can capture some events that it shouldn't.

These changes switch the menu to handling the events through the common dispatcher instead.

Fixes angular#29996.
@mmalerba mmalerba removed their request for review November 14, 2024 15:51
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 14, 2024
@crisbeto crisbeto merged commit 42f6a4a into angular:main Nov 14, 2024
21 of 23 checks passed
crisbeto added a commit that referenced this pull request Nov 14, 2024
Currently `mat-menu` handles it keyboard events in the template, however this ignores the overlay's stacking context which can capture some events that it shouldn't.

These changes switch the menu to handling the events through the common dispatcher instead.

Fixes #29996.

(cherry picked from commit 42f6a4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MatMenu): Tooltip on menu options not dismissable
2 participants