fix(material/expansion): switch away from animations module #30119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: patch
crisbeto
force-pushed
the
expansion-no-animations
branch
from
0c11393 to
1b0a288
Compare
|
Deployed dev-app for 99c87e8 to: https://ng-dev-previews-comp--pr-angular-components-30119-dev-wmtwncsw.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbeto
force-pushed
the
expansion-no-animations
branch
4 times, most recently
from
f1deed4 to
01750c7
Compare
eneajaho
reviewed
Dec 4, 2024
crisbeto
force-pushed
the
expansion-no-animations
branch
from
01750c7 to
99c87e8
Compare
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
crisbeto
force-pushed
the
expansion-no-animations
branch
from
99c87e8 to
3e2306c
Compare
crisbeto
force-pushed
the
expansion-no-animations
branch
from
3e2306c to
bcfd6c3
Compare
Reworks the expansion panel to animate purely with CSS, rather than going through the `@angular/animations` module. This simplifies the setup and allows us to resolve several long-standing bug reports. Fixes angular#27946. Fixes angular#22715. Fixes angular#21434. Fixes angular#20517. Fixes angular#17177. Fixes angular#16534. Fixes angular#16503. Fixes angular#14952. Fixes angular#14759. Fixes angular#14075. Fixes angular#11765.
crisbeto
force-pushed
the
expansion-no-animations
branch
from
bcfd6c3 to
b35c757
Compare
crisbeto
removed
the
dev-app preview
andrewseguin
approved these changes
Dec 5, 2024
crisbeto
added a commit
that referenced
this pull request
Dec 5, 2024
Reworks the expansion panel to animate purely with CSS, rather than going through the `@angular/animations` module. This simplifies the setup and allows us to resolve several long-standing bug reports. Fixes #27946. Fixes #22715. Fixes #21434. Fixes #20517. Fixes #17177. Fixes #16534. Fixes #16503. Fixes #14952. Fixes #14759. Fixes #14075. Fixes #11765. (cherry picked from commit aafa151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the expansion panel to animate purely with CSS, rather than going through the
@angular/animationsmodule. This simplifies the setup and allows us to resolve several long-standing bug reports.Fixes #27946.
Fixes #22715.
Fixes #21434.
Fixes #20517.
Fixes #17177.
Fixes #16534.
Fixes #16503.
Fixes #14952.
Fixes #14759.
Fixes #14075.
Fixes #11765.