fix(material/select): add opt-in input that allows selection of nullable options #30142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
src/material/select/select.md
Outdated
| @@ -66,6 +66,15 @@ If you want one of your options to reset the select's value, you can omit specif | |||
|
|
|||
| <!-- example(select-reset) --> | |||
|
|
|||
| ### Allowing nullable options to be selected | |||
|
|
|||
| By default any options with a `null` or `undefined` value will reset the select's value. This is | |||
There was a problem hiding this comment.
I'd probably remove the statement about mimicing native behavior, since I don't think that's the actual case anymore. It's enough to include the first sentence to basically say "this is how we handle null by default"
andrewseguin
approved these changes
Dec 10, 2024
…ble options By default `mat-select` treats options with nullable values as "reset options", meaning that they can't be selected, but rather they clear the select's value. This behavior is based on how the native `select` works, however in some cases it's not desirable. These changes add an input that users can use to opt out of the default behavior. Fixes angular#25120.
crisbeto
force-pushed
the
25120/select-nullable
branch
from
d489620 to
23d28b5
Compare
crisbeto
added a commit
that referenced
this pull request
Dec 10, 2024
…ble options (#30142) By default `mat-select` treats options with nullable values as "reset options", meaning that they can't be selected, but rather they clear the select's value. This behavior is based on how the native `select` works, however in some cases it's not desirable. These changes add an input that users can use to opt out of the default behavior. Fixes #25120. (cherry picked from commit 0296713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
mat-selecttreats options with nullable values as "reset options", meaning that they can't be selected, but rather they clear the select's value. This behavior is based on how the nativeselectworks, however in some cases it's not desirable. These changes add an input that users can use to opt out of the default behavior.Fixes #25120.