fix(material/menu): decouple menu lifecycle from animations #30148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
remove-menu-animation-delay
branch
2 times, most recently
from
7c16889 to
996d44d
Compare
crisbeto
requested review from
amysorto and
wagnermaciel
and removed request for
a team
crisbeto
added
the
merge: preserve commits
crisbeto
force-pushed
the
remove-menu-animation-delay
branch
3 times, most recently
from
996d44d to
469bd2e
Compare
Reworks the menu so that its removal isn't bound by animations. The current approach is somewhat brittle and makes it difficult to eventually switch to a fully CSS-based animation.
crisbeto
force-pushed
the
remove-menu-animation-delay
branch
from
469bd2e to
ad2039a
Compare
crisbeto
removed
merge: preserve commits
andrewseguin
approved these changes
Dec 10, 2024
crisbeto
added a commit
that referenced
this pull request
Dec 10, 2024
Reworks the menu so that its removal isn't bound by animations. The current approach is somewhat brittle and makes it difficult to eventually switch to a fully CSS-based animation. (cherry picked from commit 7739315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the menu so that its removal isn't bound by animations. The current approach is somewhat brittle and makes it difficult to eventually switch to a fully CSS-based animation.