Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/menu): remove dependency on animations module #30163

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

crisbeto
Copy link
Member

Second attempt at reworking the menu so it no longer depends on the animations module (after #30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 11, 2024
@crisbeto crisbeto force-pushed the menu-no-animations-again branch from 6644612 to 60fd630 Compare December 11, 2024 15:53
Second attempt at reworking the menu so it no longer depends on the animations module (after angular#30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.
@crisbeto crisbeto force-pushed the menu-no-animations-again branch from 60fd630 to 5329cf8 Compare December 11, 2024 18:22
@crisbeto crisbeto marked this pull request as ready for review December 12, 2024 10:34
@crisbeto crisbeto requested a review from a team as a code owner December 12, 2024 10:34
@crisbeto crisbeto requested review from amysorto and wagnermaciel and removed request for a team December 12, 2024 10:34
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 13, 2024
@crisbeto crisbeto merged commit 4620df1 into angular:main Dec 13, 2024
21 of 23 checks passed
crisbeto added a commit that referenced this pull request Dec 13, 2024
Second attempt at reworking the menu so it no longer depends on the animations module (after #30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.

(cherry picked from commit 4620df1)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jan 9, 2025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/menu target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants