fix(material/menu): remove dependency on animations module #30163
+166
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
menu-no-animations-again
branch
from
6644612 to
60fd630
Compare
Second attempt at reworking the menu so it no longer depends on the animations module (after angular#30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.
crisbeto
force-pushed
the
menu-no-animations-again
branch
from
60fd630 to
5329cf8
Compare
crisbeto
requested review from
amysorto and
wagnermaciel
and removed request for
a team
andrewseguin
approved these changes
Dec 12, 2024
This was referenced Dec 14, 2024
Closed
1 task
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 9, 2025
…ngular#30163)" This reverts commit 4620df1.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at reworking the menu so it no longer depends on the animations module (after #30099). This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks (e.g. #47748) and reduce the bundle size.