fix(material/table): improve filter predicate efficiency #30172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
andrewseguin
force-pushed
the
table-filter
branch
from
f8c96d9 to
a55765a
Compare
andrewseguin
force-pushed
the
table-filter
branch
from
a55765a to
19fb4d8
Compare
andrewseguin
added
the
target: patch
crisbeto
approved these changes
Dec 12, 2024
andrewseguin
added a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit c12b73e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the table datasource's default filter predicate so that it iterates over each data value directly rather than building a string with delimited characters.
Code was pulled and slightly modified from #21362
New logic performs quite a bit better than before: https://jsbench.me/4bkjp85g44/1