fix(cdk/testing): add code to keyboard events #30188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `UnitTestElement` dispatches keyboard event sequences, it sends out fake events which didn't have the `code` property. These changes add mappings for common keys to their codes. Fixes angular#27034.
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
crisbeto
commented
Dec 15, 2024
| return `Digit${char}`; | ||
| } | ||
|
|
||
| return charsToCodes[char] ?? ''; |
There was a problem hiding this comment.
Random thought: we could return <unsupported> here instead which would make it more obvious that our code doesn't have a mapping for the specific character.
There was a problem hiding this comment.
Sounds like a good idea to me, could potentially prevent some bad tests
andrewseguin
approved these changes
Dec 16, 2024
| return `Digit${char}`; | ||
| } | ||
|
|
||
| return charsToCodes[char] ?? ''; |
There was a problem hiding this comment.
Sounds like a good idea to me, could potentially prevent some bad tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
UnitTestElementdispatches keyboard event sequences, it sends out fake events which didn't have thecodeproperty. These changes add mappings for common keys to their codes.Fixes #27034.