-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FocusOriginMonitor): add support for touch events #3020
Conversation
src/lib/core/style/focus-classes.ts
Outdated
@@ -3,7 +3,10 @@ import {Observable} from 'rxjs/Observable'; | |||
import {Subject} from 'rxjs/Subject'; | |||
|
|||
|
|||
export type FocusOrigin = 'mouse' | 'keyboard' | 'program'; | |||
const TOUCH_BUFFER_MS = 650; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devversion I stole this number from material 1, but any idea where it comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think the timeout is still fine. I took it from angular/material#7965 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also mind exporting this variable? So the tests can use it for their setTimeout
's?
@devversion I've made the change to compare event targets that you were asking for. While it is a little simpler, I believe it is less correct than what I had previously. Consider this example:
Here the |
@mmalerba I see. I just ran your PR locally on my end and saw the issue. I went through the
This would also solve the issue you mentioned above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - We had a discussion again and the current approach works fine (Miles will add a comment)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.